Smart::Blob - introduce new xs size#689
Merged
Merged
Conversation
phndiaye
approved these changes
Jul 3, 2026
| type: 'select' | ||
| }, | ||
| options: ['sm', 'md', 'xl'] | ||
| options: ['xs', 'sm', 'md', 'xl'] |
Contributor
There was a problem hiding this comment.
nitnit: could be DRYer
Member
There was a problem hiding this comment.
@edouardmisset if you mean importing the array from the implem, Storybook can't :p (Ember hell)
Contributor
There was a problem hiding this comment.
yeah I know.
Actually I meant between L. 20 and L. 26. To have a single source of truth (at least in this file).
But it might not be worth it honestly
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/ready-to-merge
reviewed/needs-work
labels
edouardmisset
approved these changes
Jul 3, 2026
nathalieArnoux
approved these changes
Jul 3, 2026
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/ready-to-merge
labels
aprentout
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Smart::Blob - introduce new
xssizeGood PR checklist