fix: pass force_download through to snapshot_download in _get_statistics - #8906
Open
arthi-arumugam-git wants to merge 2 commits into
Open
fix: pass force_download through to snapshot_download in _get_statistics#8906arthi-arumugam-git wants to merge 2 commits into
arthi-arumugam-git wants to merge 2 commits into
Conversation
The signature accepts force_download but the call site hard-coded True, so the caller's explicit False for the repeat statistics check was discarded and every statistics run forced a download. Fixes unslothai#8899 Claude-Session: https://claude.ai/code/session_01KJrBqn4AgyHTazfdUuXbuA Signed-off-by: Arthi Arumugam <arthi1805@gmail.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8899.
The one-word passthrough:
_get_statisticsacceptedforce_downloadbut thesnapshot_downloadcall site hard-codedTrue, so the caller's explicitFalsefor therepeatstatistics check atget_statisticswas discarded.Regression test follows the repo's source-inspection pattern (same approach as
test_fast_model_config_passthrough.py), so it runs on CPU with no network:repeatcaller still requestsforce_download = False,https://claude.ai/code/session_01KJrBqn4AgyHTazfdUuXbuA