docs: Document Themes 7.0 / Toolkit 9.0 upgrade in the 6.6 migration notes - #23925
docs: Document Themes 7.0 / Toolkit 9.0 upgrade in the 6.6 migration notes#23925agneszitte wants to merge 1 commit into
Conversation
|
test seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Claude finished @agneszitte's task in 3m 11s —— View job PR Review
SummaryThis is a well-written, accurate documentation addition. Content is organized logically — impact-first (legacy dictionaries break at startup), then progressively less-common migration cases — and the "no changes needed for template apps" callout up front is valuable for reducing upgrade alarm. Findings: 1 minor
The one inline finding is on line 111: the Everything else looks good:
|
There was a problem hiding this comment.
Pull request overview
Updates the Uno Platform 6.6 migration notes to document the implicit design-system package upgrades that land in the 6.6 service release line (Uno.Themes 7.x and Uno.Toolkit 9.x), focusing on the real breaking/migration points app developers may hit.
Changes:
- Adds a new “Uno Themes 7.0 and Uno Toolkit 9.0” section under Uno Platform 6.6 migration notes.
- Documents key upgrade impacts (legacy dictionary startup failure, URI changes, theme initialization changes, obsolete color override APIs, custom theme hook changes, platform/package support shifts, and dependency floors).
- Links to the per-library migration guides via
xref.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d3ff27b to
d96feae
Compare
|
Claude finished @agneszitte's task in 2m 41s —— View job PR Review
SummaryThe documentation is well-structured and accurate. The ordering — startup-breaking change first, then progressively less common migration paths — is the right call, and the "no changes needed for template apps" callout up front is genuinely useful. Findings: 2 minor
Both inline findings are on missing migration examples rather than inaccurate content:
Other observations (no inline comment needed):
Everything else looks good: diff code blocks render correctly, XAML namespace prefixes are consistent with Uno conventions, the URI before/after table is accurate, |
aec65c6 to
0be3818
Compare
|
Claude finished @agneszitte's task in 2m 26s —— View job PR Review
SummaryWell-structured documentation addition. The impact-first ordering (startup-breaking legacy dictionaries first, then progressively less common migration paths) is the right call, and the "no changes needed for template apps" callout up front will significantly reduce upgrade alarm for the majority of users. Findings: 3 minor
Inline findings:
Everything else looks good:
|
|
Claude finished @agneszitte's task in 1m 45s —— View job PR Review
SummaryWell-structured, impact-first documentation addition. The "no changes needed for template apps" callout up front is genuinely useful for reducing upgrade alarm, and the ordering (startup-breaking case first, progressively less common paths after) is correct. Findings: 2 minor
Both inline findings are about missing migration detail, not inaccurate content:
Other observations (no inline comment):
Everything else looks good: Conventional Commits format followed ( |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23925/docs/index.html |
The 6.6 service release moves the SDK's implicit design-system pins across a major version (Uno.Themes 6.1 -> 7.0, Uno.Toolkit 8.4 -> 9.0), which was not covered by the initial 6.6 migration notes. Scoped to breaking changes and the migration steps apps need to take. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0be3818 to
9076838
Compare
|
Claude finished @agneszitte's task in 1m 43s —— View job PR Review
SummaryThe documentation is accurate and well-structured. The author has correctly addressed all findings from previous review rounds:
No new findings. Two non-blocking observations (no inline comment needed):
|
| - The UWP-flavored `Uno.Toolkit.UI` and `Uno.Toolkit.UI.Material` packages stop at 8.4.2, and neither library ships `net9.0-maccatalyst` or `net9.0-macos` assets anymore. | ||
| - Minimum dependencies are raised to `Uno.WinUI` 6.5 for the Toolkit and 6.4 for Themes, and Uno Toolkit 9.0 requires Uno Themes 7.0. Remove or update explicit pins of those packages. | ||
|
|
||
| For the per-library details, see the [Uno Toolkit](xref:Toolkit.Migration) and [Uno Material](xref:Uno.Themes.Material.Migration) upgrade guides. |
There was a problem hiding this comment.
@kazo0 the migration details after your review should move in the general xref:Toolkit.Migration and maybe best to have a more general xref:Uno.Themes.Migration instead of xref:Uno.Themes.Material.Migration
Let me know your thoughts please
There was a problem hiding this comment.
Yes indeed they should :)
These all look good!
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23925/docs/index.html |
GitHub Issue: related to https://github.com/unoplatform/private/issues/1102
PR Type:
📚 Documentation content changes
What changed? 🚀
The 6.6 migration notes covered the core and Uno.Extensions changes from the initial 6.6 release, but not the design system packages moving up a major version in the service release: the SDK's implicit pins go from Uno.Themes 6.1.1 → 7.0.3 and Uno.Toolkit 8.4.2 → 9.0.3.
This adds a short "Uno Themes 7.0 and Uno Toolkit 9.0" entry under Uno Platform 6.6, matching the length and style of the other breaking-change entries in the file — one paragraph plus a bullet list of what breaks and what to do, with links out to the per-library upgrade guides:
MaterialToolkitResourcesV1/V2dictionaries now fail at startup → use<MaterialToolkitTheme />.WinUIsuffix (affects URI-based merges).MaterialToolkitThemederives fromMaterialTheme→ don't declare<MaterialTheme />alongside it.ColorOverrideSource/ColorOverrideDictionaryobsolete → theColorsproperty:ThemeColors.OverrideSourcefor a file override,ThemeColors.OverrideDictionaryfor an inlineResourceDictionary.BaseTheme.GenerateSpecificResources()removed → the parameterlessAddThemeSpecificResources()hook, with dictionaries added throughAddThemeDictionary().CommandBarandToggleSwitchlost their iOS/Android variants.net9.0-maccatalyst/net9.0-macosassets dropped.It states up front that apps using the template pattern (
<MaterialToolkitTheme />) need no changes, so a major version bump inside a service release doesn't read as more disruptive than it is.Validation
Verified against the shipped packages rather than commit messages:
NativeCommandBarTemplate— the other missing keys live in aNavigationView/WUX/**folder the WinUI package excludes, so they never shipped.ButtonMinHeight→ControlHeightMedium,ButtonPadding→Space400HorizontalThickness, …) and tracedBaseTheme.ScaleGeneration.csto verify the token defaults equal the literals they replaced (40, 16, 20, …) at the default density and corner radius — hence "default appearance unchanged".lib/assets of all 11 Themes and Toolkit packages:net9.0-maccatalystandnet9.0-macospresent at 6.1.1/8.4.2, absent at 7.0.3/9.0.3. Last stable UWP-flavored Toolkit release is 8.4.2.BaseTheme.UpdateSource()at both versions to confirm color override precedence is unchanged for apps that don't opt into seed colors.net10.0-desktop) on both stacks — baseline (6.1.1 / 8.4.2) and upgraded (7.0.3 / 9.0.3): both build with 0 warnings / 0 errors and launch cleanly.<MaterialToolkitTheme />for<MaterialToolkitResourcesV2 />: runs on 8.4.2, crashes on 9.0.3 withCannot locate resource from 'ms-appx:///Uno.Toolkit.WinUI.Material/Generated/mergedpages.WinUI.v2.xaml'.cspell --config ./build/cSpell.jsonpasses on the edited file, and the previous push was green on Uno.UI - docs and Check Docs links, so bothxreflinks resolve in a real docs build.Following the automated review round, two points were folded in and one was declined on the evidence:
AddThemeSpecificResourcessignature is now given in the doc. Note it is parameterless (BaseTheme.cs:468at tag7.0.3) and implementers layer resources via theprotected void AddThemeDictionary(ResourceDictionary)helper — the reviewer-suggestedAddThemeSpecificResources(ResourceDictionary dictionary)overload does not exist.ThemeColors.OverrideDictionaryis confirmed against the shipped API and is now covered alongsideOverrideSource.SkiaSharp.Viewsdependency are intentionally not listed as floors a reader must act on:Uno.Sdk6.6.33 already pinsMicrosoft.WindowsAppSDKto1.7.250909003(the exact floor Toolkit 9.0.3 declares) andSkiaSharp.Views.Uno.WinUI/.WinUIare already implicit SDK packages at3.119.2, above the new3.119.1floor.PR Checklist ✅
Screenshots Compare Test Runresults — N/A, documentation-only🤖 Generated with Claude Code