Dev/bc public api phase4 - #23619
Conversation
WinAppSDK sync generator drift detected on
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
2 similar comments
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
2 similar comments
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
The build 220938 did not find any UI Test snapshots differences. |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
The build 220970 did not find any UI Test snapshots differences. |
|
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
The build 221070 found UI Test snapshots differences: Details
|
|
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
The build 221124 found UI Test snapshots differences: Details
|
|
|
Removing IEnumerable from FrameworkElement/ContentControl breaks C#
collection-initializer syntax (new Panel { child }) across tests,
samples, and user code. Reverted; needs a decision + migration sweep.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
BC16 is decided (dropped): the DependencyPropertyChangedEventArgs pool already captures the allocation win, and the struct drops precedence/ bypass fields. Delete the #if false struct and its stale commented reference instead of leaving 'bring back in Uno 6' dead code. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… (BC41) Move PointerPoint, PointerPointProperties, PointerUpdateKind and IPointerPointTransform out of Uno.UI (Microsoft.UI.Input) into Uno.UWP so Uno.UI.Composition can reference the modern type. This unblocks BC41: VisualInteractionSource/ICompositionTarget/CompositionTarget.TryRedirectForManipulation now take Microsoft.UI.Input.PointerPoint (was Windows.UI.Input.PointerPoint). Drops the legacy Windows.UI.Input pointer variant of these types (and the Microsoft<->Windows bridge), migrating in-assembly consumers (CoreWindow, PointerEventArgs, injection, InputManager, PointerRoutedEventArgs) to the modern type. GestureRecognizer/Manipulation stay in Uno.UI (Composition dep). Compile-validated on Skia + Reference + RuntimeTests. Native/WASM/other Skia hosts and interactive pointer input pending CI + device validation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d357a32 to
681e0a8
Compare
The WinAppSDKSyncGenerator's GetNamespaceBasePath routed all Microsoft.UI.Input stubs to Uno.UI; after relocating PointerPoint, PointerPointProperties, PointerUpdateKind and IPointerPointTransform to Uno.UWP, their generated stubs must be routed there too so a regen reproduces the layout. Rest of Microsoft.UI.Input stays in Uno.UI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
WinAppSDK sync generator drift detected on
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
|
The build 224987 found UI Test snapshots differences: Details
|
Follow-up to the PointerPoint relocation (BC41): migrate the platform- specific and host consumers off the removed Windows.UI.Input pointer types — PointerHelpers.Android, BrowserPointerInputSource (wasm + Browser host), FrameBuffer/Tizen input sources, and the GestureRecognizer unit test + samples. Disambiguate PointerDeviceType (Windows.Devices.Input vs Microsoft.UI.Input) with per-file aliases/casts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
WinAppSDK sync generator drift detected on
|
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
|
The build 225017 found UI Test snapshots differences: Details
|
Round-3 CI fixes: X11/Win32/MacOS/FrameBuffer/Tizen/WASM-Browser input sources + InputManager.Pointers referenced the removed Windows.UI.Input pointer types via bare names. Import Microsoft.UI.Input (needed for the PointerPointProperties extension methods) and disambiguate PointerEventArgs (-> Windows.UI.Core) and PointerDeviceType (-> Windows.Devices.Input) via per-file aliases. Validated locally: X11 + FrameBuffer hosts, Uno.UI.Skia, RuntimeTests.Skia, UnitTests all build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
WinAppSDK sync generator drift detected on
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
Apply the WinAppSDKSyncGenerator patch (re-adds the Windows.UI.Input.* NotImplemented stubs the UWP contract requires, and normalizes the moved Microsoft.UI.Input pointer stubs) so the sync-generator check passes. Fix consumers shadowed by the re-added Windows.UI.Input stubs: CoreWindow and PointerEventArgs drop the now-redundant Windows.UI.Input import; the Preview.Injection files use namespace-scoped Microsoft.UI.Input aliases (compilation-unit aliases lose to the enclosing Windows.UI.Input namespace). Validated: Uno.UWP.Skia, Uno.UI.Skia, X11 + FrameBuffer hosts, UnitTests, RuntimeTests.Skia all build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
Adds PackageDiffIgnore entries for the Phase-4 visibility reductions, navigation ctor/setter hiding, Duration.TimeSpan read-only change, and the Microsoft.UI.Input.PointerPoint family relocation (BC41). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
The BC41 relocation removed the whole `UI\Input\WinRT\*.cs` compile glob from the Uno.UWP heads, which dropped the entire Windows.UI.Input gesture/ manipulation surface (GestureRecognizer, ManipulationDelta, etc.) — not just the relocated PointerPoint family. Only the 4 PointerPoint-family files were meant to move; that removal was accidental scope creep into BC76. Restore the glob (the 4 relocated files already left the folder) and point the gesture files' PointerPoint/PointerPointProperties/PointerUpdateKind references at the relocated global::Microsoft.UI.Input types so they resolve in both namespace flavors. Revert the 14 gesture/manipulation generated stubs to their skip-already-declared form that coexists with the glob. Compile-validated: Uno.UWP Skia+Reference, Uno.UI Skia, RuntimeTests Skia. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-23619/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-23619/docs/index.html |
|
The build 225115 found UI Test snapshots differences: Details
|
GitHub Issue: closes https://github.com/unoplatform/uno-private/issues/2126, closes #13709
PR Type:
What changed? 🚀
PR Checklist ✅
Screenshots Compare Test Runresults.