Skip to content

feat(http): add variesQuery allowlist for cache-key query params (#14)#29

Open
raminjafary wants to merge 1 commit into
unjs:mainfrom
raminjafary:feat/varies-query
Open

feat(http): add variesQuery allowlist for cache-key query params (#14)#29
raminjafary wants to merge 1 commit into
unjs:mainfrom
raminjafary:feat/varies-query

Conversation

@raminjafary

Copy link
Copy Markdown

Resolves #14.

Only allowlisted query params vary the auto-generated cache key; all others (including random cache-busters) are ignored. Ignored params are also stripped from the URL the handler receives — mirroring the existing non-varies header filtering — so a handler can never produce output that depends on a param outside the key.

Param order is normalized and repeated array params are matched order-independently. variesQuery: [] varies by nothing; unset keeps the full-query behavior.

…njs#14)

Only allowlisted query params vary the auto-generated cache key; all
others (including random cache-busters) are ignored. Ignored params are
also stripped from the URL the handler receives — mirroring the existing
non-`varies` header filtering — so a handler can never produce output
that depends on a param outside the key.

Param order is normalized and repeated array params are matched
order-independently. `variesQuery: []` varies by nothing; unset keeps
the full-query behavior.
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@raminjafary, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a7b41a35-5a71-4b27-a9af-9d1d761a3168

📥 Commits

Reviewing files that changed from the base of the PR and between b0339a2 and 5720fb8.

📒 Files selected for processing (4)
  • README.md
  • src/http.ts
  • src/types.ts
  • test/index.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

defineCachedHandler: include/exclude query params

1 participant