feat: warn when recompute is cheaper than cache retrieval#28
Open
raminjafary wants to merge 1 commit into
Open
feat: warn when recompute is cheaper than cache retrieval#28raminjafary wants to merge 1 commit into
raminjafary wants to merge 1 commit into
Conversation
Add an opt-in `warnWhenSlower` option that times cache retrieval vs. recompute and emits a one-time console.warn when retrieval is non-trivial and recomputing the value is meaningfully cheaper (i.e. caching adds net overhead). Requires retrieval above a small floor and a clear margin over recompute, so fast/local storage and sub-millisecond noise never trigger it. Off by default; negligible cost when disabled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
👮 Files not reviewed due to content moderation or server errors (4)
📝 Walkthrough
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
warnWhenSloweroption toCacheOptions. When enabled, ocachetimes cache retrieval (a hit
get) against recompute (the resolver on a miss/refresh) and emits a one-time
console.warnwhen recomputing the value ischeaper than reading it back from the cache — i.e. caching is adding net
overhead for that cache.
so integrity hashing is unaffected. Handles request dedup and SWR refreshes.
defineCachedFunctionanddefineCachedHandler.Addresses nitrojs/nitro#2559/nitrojs/nitro#4401 (Nitro enables it in dev via
import.meta.dev).Usage: