feat: support appendMissingElements (arrayUnion) in YustFieldTransform - #417
Open
CLNMR wants to merge 1 commit into
Open
feat: support appendMissingElements (arrayUnion) in YustFieldTransform#417CLNMR wants to merge 1 commit into
CLNMR wants to merge 1 commit into
Conversation
Adds `appendMissingElements` to `YustFieldTransform` so callers can ask Firestore to union values into an array field. Wired through both the Dart (`googleapis/firestore`) and Flutter (`cloud_firestore`) variants. Also makes `YustDatabaseServiceMocked.updateDocByTransform` honor the full transform set (`appendMissingElements`, `removeFromArray`, `setToServerTimestamp`, `delete`) instead of treating every transform as an `increment`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendMissingElementstoYustFieldTransform, wired through both the Dart (googleapis/firestore→ArrayValue) and Flutter (cloud_firestore→FieldValue.arrayUnion) variants so callers can union values into an array field.YustDatabaseServiceMocked.updateDocByTransformto honor the full transform set (appendMissingElements,removeFromArray,setToServerTimestamp,delete) instead of treating every transform as anincrement.3.34.0.Test plan
YustFieldTransform(fieldPath: ..., appendMissingElements: [...])round-trips throughcloud_firestoreand produces the correctFieldValue.arrayUnion(...)op.FieldTransformwithappendMissingElementsset on the REST request.DeepCollectionEquality), andremoveFromArray/setToServerTimestamp/deleteno longer fall through to the increment path.🤖 Generated with Claude Code