fix: await useAuthEmulator before completing Yust.initialize - #416
Open
CLNMR wants to merge 1 commit into
Open
Conversation
FirebaseAuth.useAuthEmulator(host, port) returns a Future<void>. On web the underlying JS connectAuthEmulator does not take effect synchronously, so any auth call (e.g. signInWithMicrosoft) started before that future resolves hits production endpoints instead of the emulator. Expose a `ready` future on the auth services and await it from Yust.initialize so callers can rely on the emulator being fully wired when initialization returns. The Dart-only and mocked variants get a no-op `ready` to keep the interface symmetric. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FirebaseAuth.useAuthEmulator(host, port)returns aFuture<void>; on web the underlying JSconnectAuthEmulatordoesn't take effect synchronously, so auth calls (e.g.signInWithMicrosoft) started before that future resolves hit production endpoints instead of the emulator.readyfuture onYustAuthServiceand awaits it fromYust.initialize, so callers can rely on the emulator being fully wired by the time initialization returns.readyto keep the interface symmetric.Test plan
Yust.initialize(emulatorAddress: 'localhost', ...), federated sign-ins (Microsoft/Google) now hithttp://localhost:9099/emulator/auth/handler...instead of the production OAuth handler at<authDomain>/__/auth/handler.Yust.initializestill completes immediately —readyis a pre-completedFuture.value()there.🤖 Generated with Claude Code