Always generate id in doc constructor

lib/src/models/yust_doc.dart

@@ -87,15 +87,15 @@ abstract class YustDoc {
   bool get hasChanges => _updateMask.isNotEmpty;
 
   YustDoc({
-    String id = '',
+    String? id,
     DateTime? createdAt,
     String? createdBy,
     DateTime? modifiedAt,
     String? modifiedBy,
     String? userId,
     String? envId,
     DateTime? expiresAt,
-  }) : _id = id,
+  }) : _id = id ?? createDocumentId(),
        _createdAt = createdAt,
        _createdBy = createdBy,
        _modifiedAt = modifiedAt,
@@ -104,8 +104,6 @@ abstract class YustDoc {
        _envId = envId,
        _expiresAt = expiresAt;
 
-  YustDoc.fromJson(Map<String, dynamic> json) : _id = '';
-
   Map<String, dynamic> toJson();
 
   Map<String, dynamic> toExportJson() {
@@ -125,6 +123,11 @@ abstract class YustDoc {
     return GoogleCloudHelpers.convertTimestamp(value);
   }
 
+  /// Creates a new document ID.
+  static String createDocumentId() {
+    return Yust.helpers.randomString(length: 20);
+  }
+
   /// clear the update mask
   void clearUpdateMask() => updateMask.clear();
 }

lib/src/models/yust_user.dart

@@ -186,6 +186,14 @@ class YustUser extends YustDoc {
   Map<String, dynamic> get userAttributes => Map.unmodifiable(_userAttributes);
 
   YustUser({
+    super.id,
+    super.createdAt,
+    super.createdBy,
+    super.modifiedAt,
+    super.modifiedBy,
+    super.userId,
+    super.envId,
+    super.expiresAt,
     required String email,
     required String firstName,
     required String lastName,

lib/src/services/yust_database_service_dart.dart

@@ -107,7 +107,7 @@ class YustDatabaseService implements IYustDatabaseService {
   /// assigned a new id becoming a new document if it had an id previously.
   @override
   T initDoc<T extends YustDoc>(YustDocSetup<T> docSetup, [T? doc]) {
-    final id = _createDocumentId();
+    final id = YustDoc.createDocumentId();
     return doInitDoc(docSetup, id, doc);
   }
 
@@ -1504,6 +1504,13 @@ class YustDatabaseService implements IYustDatabaseService {
       return null;
     }
 
+    if (json['id'] is! String || json['id'].isEmpty) {
+      print(
+        '[[WARNING]] Error Transforming JSON. Document has no id: Collection ${docSetup.collectionName}, Name ${document.name}',
+      );
+      return null;
+    }
+
     try {
       final doc = docSetup.fromJson(json);
       doc.clearUpdateMask();
@@ -1615,10 +1622,6 @@ class YustDatabaseService implements IYustDatabaseService {
     }
   }
 
-  String _createDocumentId() {
-    return Yust.helpers.randomString(length: 20);
-  }
-
   /// Retries the given function if a TlsException, ClientException or YustBadGatewayException occurs.
   /// Those are network errors that can occur when the firestore is rate-limiting.
   Future<T> _retryOnException<T>(

lib/src/services/yust_database_service_flutter.dart

@@ -35,36 +35,35 @@ class YustDatabaseService implements IYustDatabaseService {
   final Yust _yust;
 
   YustDatabaseService({required Yust yust, String? emulatorAddress})
-    : _yust = yust,
-      envCollectionName = yust.envCollectionName,
-      useSubcollections = yust.useSubcollections,
-      _fireStore = FirebaseFirestore.instance {
-    dbLogCallback =
-        (
-          DatabaseLogAction action,
-          String documentPath,
-          int count, {
-          String? id,
-          List<String>? updateMask,
-          num? aggregationResult,
-        }) {
-          statistics.dbStatisticsCallback(
-            action,
-            documentPath,
-            count,
-            id: id,
-            updateMask: updateMask,
-            aggregationResult: aggregationResult,
-          );
-          yust.dbLogCallback?.call(
-            action,
-            documentPath,
-            count,
-            id: id,
-            updateMask: updateMask,
-            aggregationResult: aggregationResult,
-          );
-        };
+      : _yust = yust,
+        envCollectionName = yust.envCollectionName,
+        useSubcollections = yust.useSubcollections,
+        _fireStore = FirebaseFirestore.instance {
+    dbLogCallback = (
+      DatabaseLogAction action,
+      String documentPath,
+      int count, {
+      String? id,
+      List<String>? updateMask,
+      num? aggregationResult,
+    }) {
+      statistics.dbStatisticsCallback(
+        action,
+        documentPath,
+        count,
+        id: id,
+        updateMask: updateMask,
+        aggregationResult: aggregationResult,
+      );
+      yust.dbLogCallback?.call(
+        action,
+        documentPath,
+        count,
+        id: id,
+        updateMask: updateMask,
+        aggregationResult: aggregationResult,
+      );
+    };
   }
 
   /// Represents the collection name for the tenants.
@@ -76,10 +75,10 @@ class YustDatabaseService implements IYustDatabaseService {
   final bool useSubcollections;
 
   YustDatabaseService.mocked({required Yust yust, String? emulatorAddress})
-    : _yust = yust,
-      envCollectionName = yust.envCollectionName,
-      useSubcollections = yust.useSubcollections,
-      dbLogCallback = yust.dbLogCallback {
+      : _yust = yust,
+        envCollectionName = yust.envCollectionName,
+        useSubcollections = yust.useSubcollections,
+        dbLogCallback = yust.dbLogCallback {
     throw UnsupportedError('Not supported in Flutter Environment');
   }
 
@@ -97,12 +96,12 @@ class YustDatabaseService implements IYustDatabaseService {
         .get(GetOptions(source: Source.serverAndCache))
         .then((docSnapshot) => _transformDoc<T>(docSetup, docSnapshot))
         .catchError((e) {
-          if (e is FirebaseException && e.code == 'permission-denied') {
-            print('Permission denied for doc: ${docSetup.collectionName}/$id');
-            return null;
-          }
-          throw e;
-        });
+      if (e is FirebaseException && e.code == 'permission-denied') {
+        print('Permission denied for doc: ${docSetup.collectionName}/$id');
+        return null;
+      }
+      throw e;
+    });
     dbLogCallback?.call(
       DatabaseLogAction.get,
       _getCollectionPath(docSetup),
@@ -167,13 +166,13 @@ class YustDatabaseService implements IYustDatabaseService {
         .doc(id)
         .snapshots()
         .map((docSnapshot) {
-          dbLogCallback?.call(
-            DatabaseLogActionExtension.fromSnapshot(docSnapshot),
-            docSnapshot.reference.parent.path,
-            docSnapshot.exists ? 1 : 0,
-          );
-          return _transformDoc(docSetup, docSnapshot);
-        });
+      dbLogCallback?.call(
+        DatabaseLogActionExtension.fromSnapshot(docSnapshot),
+        docSnapshot.reference.parent.path,
+        docSnapshot.exists ? 1 : 0,
+      );
+      return _transformDoc(docSetup, docSnapshot);
+    });
   }
 
   @override
@@ -419,9 +418,8 @@ class YustDatabaseService implements IYustDatabaseService {
     int? limit,
   }) async {
     var query = getQuery(docSetup, filters: filters);
-    final snapshot = await query
-        .aggregate(cf.average(fieldPath), cf.count())
-        .get();
+    final snapshot =
+        await query.aggregate(cf.average(fieldPath), cf.count()).get();
     return (count: snapshot.count ?? 0, result: snapshot.getAverage(fieldPath));
   }
 
@@ -704,9 +702,8 @@ class YustDatabaseService implements IYustDatabaseService {
     YustDocSetup<T> docSetup,
     T doc,
   ) async {
-    final docRef = _fireStore
-        .collection(_getCollectionPath(docSetup))
-        .doc(doc.id);
+    final docRef =
+        _fireStore.collection(_getCollectionPath(docSetup)).doc(doc.id);
     await docRef.delete();
     dbLogCallback?.call(
       DatabaseLogAction.delete,
@@ -721,9 +718,8 @@ class YustDatabaseService implements IYustDatabaseService {
     YustDocSetup<T> docSetup,
     String docId,
   ) async {
-    final docRef = _fireStore
-        .collection(_getCollectionPath(docSetup))
-        .doc(docId);
+    final docRef =
+        _fireStore.collection(_getCollectionPath(docSetup)).doc(docId);
     await docRef.delete();
     dbLogCallback?.call(
       DatabaseLogAction.delete,
@@ -956,6 +952,11 @@ class YustDatabaseService implements IYustDatabaseService {
     }
     final data = snapshot.data();
     if (data is Map<String, dynamic>) {
+      if (data['id'] is! String || data['id'].isEmpty) {
+        print(
+            '[[WARNING]] Error Transforming JSON. Document has no id: ${snapshot.reference.path}');
+        return null;
+      }
       // Convert Timestamps to ISOStrings
       final modifiedData = TraverseObject.traverseObject(data, (currentNode) {
         // Convert Timestamp to Iso8601-String, as this is the format json_serializable expects