Split functions between architectures, make register access type-safe - #9
Open
funsafemath wants to merge 11 commits into
Open
Split functions between architectures, make register access type-safe#9funsafemath wants to merge 11 commits into
funsafemath wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers are now correct by construction, so reads/writes now return T instead of Result<T, E> (hopefully unicorn never returns an error for a valid register), also CPU-specific associated functions like reg_write_arm_coproc are now implemented parametrized types like Unicorn<D, Arm>
The arch parameter should probably be the first one, as the data parameter is usually inferred or is equal to the unit type, and it may be a good idea to set a default value for it (unit type), which is possible only if it's the trailing generic parameter