-
Notifications
You must be signed in to change notification settings - Fork 0
Add BDD test suite covering V2 SDK functionality #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
b3y0urs3lf
wants to merge
2
commits into
main
Choose a base branch
from
bdd-phase-0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
src/test/java/org/unicitylabs/sdk/e2e/CucumberTestRunner.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package org.unicitylabs.sdk.e2e; | ||
|
|
||
| import io.cucumber.junit.platform.engine.Constants; | ||
| import org.junit.platform.suite.api.ConfigurationParameter; | ||
| import org.junit.platform.suite.api.IncludeEngines; | ||
| import org.junit.platform.suite.api.SelectPackages; | ||
| import org.junit.platform.suite.api.Suite; | ||
|
|
||
| @Suite | ||
| @IncludeEngines("cucumber") | ||
| @SelectPackages("org.unicitylabs.sdk.features") | ||
| @ConfigurationParameter( | ||
| key = Constants.GLUE_PROPERTY_NAME, | ||
| value = "org.unicitylabs.sdk.e2e.steps," | ||
| + "org.unicitylabs.sdk.e2e.steps.shared," | ||
| + "org.unicitylabs.sdk.e2e.config") | ||
| @ConfigurationParameter( | ||
| key = Constants.PLUGIN_PROPERTY_NAME, | ||
| value = "pretty," | ||
| + "html:build/cucumber-reports/cucumber.html," | ||
| + "json:build/cucumber-reports/cucumber.json") | ||
| @ConfigurationParameter( | ||
| key = Constants.EXECUTION_DRY_RUN_PROPERTY_NAME, | ||
| value = "false") | ||
| @ConfigurationParameter( | ||
| key = Constants.PLUGIN_PUBLISH_QUIET_PROPERTY_NAME, | ||
| value = "true") | ||
| // Default tag filter — excludes nametag-gated scenarios (blocked until UnicityId | ||
| // lands), load/perf scenarios, and work-in-progress. Overridable by passing | ||
| // -Dcucumber.filter.tags=<expr> on the command line; system properties take | ||
| // precedence over @ConfigurationParameter defaults per JUnit Platform spec. | ||
| @ConfigurationParameter( | ||
| key = Constants.FILTER_TAGS_PROPERTY_NAME, | ||
| value = "not @slow and not @wip and not @ignore " | ||
| + "and not @bft-shard-only and not @multi-shard-only " | ||
| + "and not @pending-src-cleanup " | ||
| + "and not @stateful and not @fresh-aggregator") | ||
| public class CucumberTestRunner { | ||
| } |
37 changes: 37 additions & 0 deletions
37
src/test/java/org/unicitylabs/sdk/e2e/config/CucumberConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package org.unicitylabs.sdk.e2e.config; | ||
|
|
||
| import io.cucumber.java.After; | ||
| import io.cucumber.java.Before; | ||
| import io.cucumber.java.Scenario; | ||
| import org.unicitylabs.sdk.e2e.context.TestContext; | ||
|
|
||
| /** | ||
| * Cucumber lifecycle hooks. Cucumber's PicoContainer creates one instance per scenario and | ||
| * injects the shared {@link TestContext}, ensuring the same context reaches every step class | ||
| * that takes it as a constructor parameter. | ||
| */ | ||
| public class CucumberConfiguration { | ||
|
|
||
| private final TestContext testContext; | ||
|
|
||
| public CucumberConfiguration(TestContext testContext) { | ||
| this.testContext = testContext; | ||
| } | ||
|
|
||
| @Before | ||
| public void beforeScenario(Scenario scenario) { | ||
| testContext.clearTestState(); | ||
| System.out.println("[BDD] >>> " + scenario.getName()); | ||
| } | ||
|
|
||
| @After | ||
| public void afterScenario(Scenario scenario) { | ||
| System.out.println( | ||
| "[BDD] <<< " + scenario.getName() + " — " + scenario.getStatus()); | ||
| } | ||
|
|
||
| @After("@reset") | ||
| public void fullReset() { | ||
| testContext.reset(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigning to
systemPropertiesreplaces the entire map of system properties for the test task. This causes thecucumber.junit-platform.naming-strategyproperty set on the previous line to be lost unless it is also present in the host JVM's system properties. Use thesystemProperties()method instead to append properties to the existing map. This pattern is repeated in several other BDD tasks (bddNametag,bddSlow, etc.).