Fix persisted-nodes gauge#163
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the SMTNodesPersistedTotal metric to track aggregator records (SMT leaves) from MongoDB instead of SMT nodes, which are stored in RocksDB. To support this, the EstimatedCount method was added to the AggregatorRecordStorage interface and implemented for MongoDB. Feedback suggests that adding this method to the interface may break existing mock implementations or alternative storage backends. Additionally, because the metric name aggregator_smt_nodes_persisted_total is now misleading, it is recommended to deprecate it in favor of a more accurately named metric.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.