Skip to content

Fix persisted-nodes gauge#163

Merged
jait91 merged 3 commits into
mainfrom
fix/smt-persisted-metric
Jun 19, 2026
Merged

Fix persisted-nodes gauge#163
jait91 merged 3 commits into
mainfrom
fix/smt-persisted-metric

Conversation

@jait91

@jait91 jait91 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SMTNodesPersistedTotal metric to track aggregator records (SMT leaves) from MongoDB instead of SMT nodes, which are stored in RocksDB. To support this, the EstimatedCount method was added to the AggregatorRecordStorage interface and implemented for MongoDB. Feedback suggests that adding this method to the interface may break existing mock implementations or alternative storage backends. Additionally, because the metric name aggregator_smt_nodes_persisted_total is now misleading, it is recommended to deprecate it in favor of a more accurately named metric.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/storage/interfaces/interfaces.go
Comment thread internal/metrics/metrics.go
@jait91
jait91 merged commit 9d53a78 into main Jun 19, 2026
3 checks passed
@jait91
jait91 deleted the fix/smt-persisted-metric branch June 19, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant