fix(marketplace): neutral category chip + frameless logo on ProjectPage#423
Closed
KruGoL wants to merge 1 commit into
Closed
fix(marketplace): neutral category chip + frameless logo on ProjectPage#423KruGoL wants to merge 1 commit into
KruGoL wants to merge 1 commit into
Conversation
- category chip no longer tinted with the project accentColor — dark accents (e.g. #000000) made it unreadable; neutral chip style matches the tag chips - drop the border-4 frame around ProjectLogo, mirroring the frame removal on the dev-portal/backoffice overview pages and the sphere-ui cards
Collaborator
Author
|
Superseded by #424 (combined into one PR per repo; this commit is included there). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two readability/consistency issues on the marketplace project page, both caused by trusting arbitrary project data for chrome styling:
accentColor(background, text and border). With dark accents (e.g.#000000) the chip becomes unreadable.border-4frame — the same mismatched-frame pattern already removed from the dev-portal and backoffice overview pages.Fix
ProjectLogo, consistent with the sphere-ui cards (see fix(media): logo tile polish — no crop, no gloss over real logos, neutral chips sphere-ui#17).Pairs with unicity-sphere/sphere-ui#17; no dependency between the two — this one only touches wallet-local markup.