feat: auto-fit images (center-crop + downscale) in MediaUploader instead of rejecting#14
Merged
Merged
Conversation
…ead of rejecting
When an image missed a kind's aspect ratio or exceeded its max dimensions,
MediaUploader rejected it ("Wrong aspect ratio" / "Image too large"). Now it
auto-fits: center-crop to the kind's aspectRatio and downscale to
maxWidth/maxHeight via canvas, then upload the corrected image (the preview shows
the result).
No-op for SVG and when canvas / createImageBitmap is unavailable (older browsers,
jsdom) — there the existing dimension check stays as the fallback so the server is
not 422'd. Because this lives in the shared MediaUploader, every consumer
(dev-portal, backoffice) gets it. An interactive cropper for logo/banner is a
planned follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an image missed a kind's aspect ratio or exceeded its max dimensions,
MediaUploader rejected it ("Wrong aspect ratio" / "Image too large"). Now it
auto-fits: center-crop to the kind's aspectRatio and downscale to
maxWidth/maxHeight via canvas, then upload the corrected image (the preview shows
the result).
No-op for SVG and when canvas / createImageBitmap is unavailable (older browsers,
jsdom) — there the existing dimension check stays as the fallback so the server is
not 422'd. Because this lives in the shared MediaUploader, every consumer
(dev-portal, backoffice) gets it. An interactive cropper for logo/banner is a
planned follow-up.