feat: add deferUpload mode to MediaGallery#12
Merged
Conversation
MediaGallery uploaded screenshots immediately, which needs an existing ownerId, so it could not be used on entity-create forms (no project id yet). Add a deferUpload mode mirroring MediaUploader's: chosen screenshots are kept locally (File + blob preview, reorderable) and the current File list is emitted via onFilesChange, so the parent uploads them after the entity exists and patches media. Non-defer behaviour is unchanged. Dimension validation still applies (the inner MediaUploader runs it before onFileSelected). Adds a test for the defer path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaGallery uploaded screenshots immediately, which needs an existing ownerId, so
it could not be used on entity-create forms (no project id yet). Add a deferUpload
mode mirroring MediaUploader's: chosen screenshots are kept locally (File + blob
preview, reorderable) and the current File list is emitted via onFilesChange, so
the parent uploads them after the entity exists and patches media.
Non-defer behaviour is unchanged. Dimension validation still applies (the inner
MediaUploader runs it before onFileSelected). Adds a test for the defer path.