feat: report duplicate group counts in the dq summary - #507
Open
Javiershenbc wants to merge 5 commits into
Open
Conversation
The group id/size columns are metadata, not 0/1 checks, so METADATA_CHECK_KEYS filtered them out of the aggregation. Aggregate them separately and expose count_duplicate_location_groups and count_proximity_50m_groups, counted only over approved rows, with their thresholds so the PDF label cannot drift from the number. Omitted when the columns are absent, so other pipelines are unchanged.
Set DUPLICATE_LOCATION_GROUP_MIN_SIZE PROXIMITY_50M_GROUP_MIN_SIZE variables, they also can be set from env vars
"DQ Check Category" is free text and becomes a top-level key of dq-summary.json, so "location checks" and "location_checks" shipped as two sections and split the location tier in half. Normalise to snake_case, and move the two "critical checks" comparisons to a shared constant so they cannot drift from it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group id/size columns are metadata, not 0/1 checks, so METADATA_CHECK_KEYS filtered them out of the aggregation. Aggregate them separately and expose count_duplicate_location_groups and count_proximity_50m_groups, counted only over approved rows, with their thresholds so the PDF label cannot drift from the number. Omitted when the columns are absent, so other pipelines are unchanged.