Skip to content

chore(release): link the EAS project and set version 0.0.1 - #76

Merged
jag3773 merged 3 commits into
mainfrom
chore/link-eas-project
Oct 8, 2026
Merged

jag3773 merged 3 commits into
mainfrom
chore/link-eas-project

Conversation

@jag3773

@jag3773 jag3773 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Part of #44.

eas init --id 047f36eb-f4b6-46a5-8668-ea6088f77d8f cannot write to a dynamic app.config.ts, so this sets the link by hand:

  • extra.eas.projectId = 047f36eb-f4b6-46a5-8668-ea6088f77d8f
  • slug: unfoldingword → uw-app (the Expo project's slug; EAS rejects a mismatch)
  • owner: unfoldingword (the project belongs to the org, not the logged-in user)
  • README release note updated to match

scheme stays unfoldingword, so deep links are unchanged.

Verified locally

  • eas project:info → @unfoldingword/uw-app, ID 047f36eb-…
  • npx expo config --type public shows slug, owner and projectId
  • npm run check, npm run typecheck, npm test (823 passed), npm run checks (9 pass)

Still open on #44

  • Add EXPO_TOKEN as a repository secret (an unfoldingWord Expo robot token)
  • Push a v* tag to prove one preview build through .github/workflows/release.yml

🤖 Generated with Claude Code

jag3773 and others added 2 commits October 6, 2026 09:28
eas init cannot write to a dynamic app.config.ts, so the project id is set
by hand. The Expo project's slug is uw-app and it belongs to the
unfoldingword organization, so slug and owner change to match; without them
EAS rejects the project id as mismatched.

Refs #44

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The first release tag is v0.0.1; the config and package versions match it.

Refs #44

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@jag3773 jag3773 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA review of PR #76. One low-priority documentation finding is attached inline.

Standards

Please record the EAS linkage in the proposal required for changes to app.config.ts. No other actionable standards or code-smell findings.

Spec

No functional defect found in the scoped project-linkage implementation. The README matches the configuration; the existing locale gate, deep-link scheme, native identifiers, permissions, and disabled OTA updates are preserved. The subsequent version-only commit 5f83e3 consistently sets app.config.ts, package.json, and both root package-lock.json version fields to 0.0.1.

Independent validation on e4ca30a: full npm run verify passed, including lint/format, all three TypeScript projects, 823 tests across 88 files, unused-code/repository checks, 63 simulation scenarios, traceability, content contracts, and Android/iOS bundles. Expo public-config assertions passed in release, draft-locale, and APK-installer modes. I also reviewed successful GitHub verification, screenshot, Android, and iOS workflow results for that commit, including native builds and simulator-flow steps. The later version-only commit was inspected, but the suite was not rerun on it.

Limits: I did not independently authenticate to the Expo project, inspect EXPO_TOKEN, perform a signed EAS build, or test on physical phones. The token and tagged release-build proof remain the explicit follow-ups in #44. The live content check reported its already-known formation-archive HTTP 500 gap while passing; it is unrelated to this diff.

Totals: Standards 1 documentation finding; Spec 0 findings.

Comment thread app.config.ts

const localeGate = process.env.UW_LOCALE_GATE === 'drafts' ? 'drafts' : 'reviewed';

const easProjectId = '047f36eb-f4b6-46a5-8668-ea6088f77d8f';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Record the EAS linkage in the required configuration proposal

AGENTS.md rule 4 includes app.config.* among shared roots, and section 9 requires a proposal with Problem, Change, Alternatives, and Rules affected. This PR changes the project ID, owner, and slug without adding or updating that record. The existing docs/proposals/2026-09-30-native-release-config.md covers store identifiers, backups/permissions, and build numbering, but not this EAS linkage. Please extend that proposal or add a short EAS-linkage proposal documenting the values and referencing issue #44's decision. Issue #44 already authorizes linking the project; this asks for the required decision record, not another approval round.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 1960f63: docs/proposals/2026-10-08-eas-project-link.md records the project id, slug, owner and the 0.0.1 version, with the alternatives and rule 4.

@jag3773 jag3773 changed the title Link the app to the EAS project chore(release): link the EAS project and set version 0.0.1 Oct 8, 2026
@jag3773
jag3773 merged commit 43fe185 into main Oct 8, 2026
5 checks passed
@jag3773
jag3773 deleted the chore/link-eas-project branch October 8, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant