Repository navigation
Add call-state watch command/helper (control-only, over status RPC) - #3
Merged
Merged
Conversation
Adds a control-only convenience for CLI and library users: poll `status` and emit a JSON event when the call state changes (started/ended/changed), instead of hand-rolling a polling loop. No new bridge action, no media/streaming, no new private API, no SIP/helper requirement beyond what `status` already needs. - private_api::StatusWatcher: pure, device-free change detection over successive BridgeResponse status payloads; tolerant of the status field naming. - CLI `watch [--interval-ms N] [--count N] [--json]`. - 6 unit tests, no live call or injected helper required. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
undivisible
marked this pull request as ready for review
October 15, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for review.
What: a
watchcommand +StatusWatcherlibrary helper that polls the existingstatusRPC and emits a JSON event when the call state changes (started/ended/changed). Lets CLI/crate users react to calls starting or ending without writing their own polling loop.Scope: control-only. No new bridge action, no media/streaming, no additional private API, and no SIP/helper requirement beyond what
statusalready needs.Testing:
StatusWatcherchange detection is pure and device-free — 6 unit tests cover baseline/no-change/started/ended/array-shaped/unknown-shape.cargo fmt,cargo clippy --features cli -- -D warnings, andcargo test --features cliare clean. Not exercised against a live call (consistent with the crate's "not verified end-to-end" posture).Usage:
🤖 Generated with Claude Code