Harden external URL handling in Electron#637
Open
72897 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small allowlist before forwarding renderer-created window open requests to Electron's
shell.openExternal.Only
https:,http:, andmailto:URLs are forwarded to the operating system. Invalid URLs and unsupported schemes are denied through the existingsetWindowOpenHandlerpath.Verification:
npx eslint src/presentation/electron/main/index.ts --max-warnings=0 --ignore-path .gitignorenpm run build -- --mode productionnpm audit --json --omit=dev