Implement Dark Theme and Theme Switcher#537
Open
cactysman wants to merge 1 commit into
Open
Conversation
Author
|
Also I just blindly picked the "Twilight" theme (view themes here) for the Ace editor in the dark theme, that might require some more decision-making to find something that looks nice and fits in with the rest of the color scheme (note that the color for highlighted code has been and still is custom, though). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are a take on implementing a dark theme (and a theme switcher) for #205.
@media(prefers-color-scheme: dark)stylingTheThemeChangercomponent has been implemented similar to howTheViewChangerwas implementedTheThemeChangercomponentNote
The way the color variable management looks now might actually be a little sloppy and since I'm not a designer, the dark colors might not be ideal at all, but it's a starting point!