Added Query Parameters#382
Conversation
680515d to
c2d3cdd
Compare
e45cf4f to
d77c3cb
Compare
|
I was thinking about this and here's my feedback to get this on production as part of Separate all query handling to its own hook It's better to separate all URL/routing logic to a separate hook. This way we achieve better separation of concern and can test it update it accordingly. This means that instead of updating three To design this we can get inspiration from Vue Router. They use a hook called We then need to move the code you written from three components to this hook. Maybe three private functions like Then there are two issues:
So we should to exactly how the other UI display components are doing. They primarily inject user selection and collection states to handle this. You can see Btw there was a linting error so it's good to run Hope this was clear, please ask if I was not clear on this and you need more information / or you do not agree @plantindesk. This is first time I collaborate someone with someone on UI source code and designing a complex feature, so things may not be well documented/explained. |
4578a0d to
a05a600
Compare
65b10a3 to
9e8bad0
Compare
c22eab2 to
0900492
Compare
c6abab3 to
080047d
Compare
080047d to
2f8aaf4
Compare
e5346d1 to
2f2813e
Compare
25d0d37 to
e6c52db
Compare
aae488a to
3d98c6d
Compare
e3cc404 to
bfd1b72
Compare
298af54 to
07bf5df
Compare
f3ad28a to
dfbcb12
Compare
qassearchparemeterpresetfor changing thepresettoStandard,Strictetccollectionthat changes to user definedosI apologize for sending pull request very late