Make the log level configurable and add timestamps to the log output - #163
Open
afroch wants to merge 3 commits into
Open
Make the log level configurable and add timestamps to the log output#163afroch wants to merge 3 commits into
afroch wants to merge 3 commits into
Conversation
The log level can now be set with the UPP_LOG_LEVEL environment variable or with the --log-level flag, which wins over the environment variable. Every log message carries the date and time, debug and info messages are written to stdout and warnings and above to stderr, so in a batch job the .err file only contains the problems. The console width is taken from the terminal instead of being hard coded, and the section banners adapt to it.
Contributor
|
Docs preview: https://umami-hep.github.io/umami-preprocessing/pr-163/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 95.34% 95.73% +0.39%
==========================================
Files 25 25
Lines 2340 2367 +27
==========================================
+ Hits 2231 2266 +35
+ Misses 109 101 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the following changes
UPP_LOG_LEVELenvironment variable or with the--log-levelflag, where the flag wins over the environment variable.errfile only contains the problemsRelates to the following issues
Conformity