Skip to content

Distributions Pre/Post tag - #279

Open
nikitapond wants to merge 9 commits into
umami-hep:mainfrom
nikitapond:preposttag
Open

Distributions Pre/Post tag#279
nikitapond wants to merge 9 commits into
umami-hep:mainfrom
nikitapond:preposttag

Conversation

@nikitapond

Copy link
Copy Markdown
Contributor

Summary

This pull request introduces the following changes

  • Adds a new plot to the high level interface, pre/post tag
  • This plots a given jet-level distribution before and after a tagger working point has been applied.

Conformity

@samvanstroud

Copy link
Copy Markdown
Contributor

Looks good to me, thanks @npond. CI is red though, could you take a look?

@codecov

codecov Bot commented Sep 21, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.94%. Comparing base (7a81d83) to head (e2a8701).
⚠️ Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
puma/hlplots/results.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   97.97%   97.94%   -0.03%     
==========================================
  Files          51       51              
  Lines        5125     5170      +45     
==========================================
+ Hits         5021     5064      +43     
- Misses        104      106       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samvanstroud

Copy link
Copy Markdown
Contributor

Thanks @npond, can you make sure this is covered by tests?

@dkobylianskii

Copy link
Copy Markdown
Contributor

Hi @nikitapond ,

Do we still need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants