Accept normalized CLA signature comments - #29
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
1 similar comment
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed .github/workflows/cla.yml. The change is narrowly scoped to allow normalized signature comments through the workflow gate while preserving exact recheck handling. No genuine issues found. LGTM.
|
🎉 Thank you @glenn-jocher for merging this PR!
This focused workflow update helps properly formatted CLA comments reach the normalized signature matcher while preserving the existing exact-match behavior for |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to accept comments containing the standard CLA signature text, allowing surrounding whitespace or Markdown to reach the action’s normalized signature matcher.
📊 Key Changes
.github/workflows/cla.ymlfrom exact equality to acontains()check.recheckcommand’s exact-match behavior unchanged.🎯 Purpose & Impact
recheckbehavior changes.