chore: Updating SRE contact email address (SR-4422)#268
Merged
Conversation
Contributor
|
Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run |
Contributor
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 7895fd7 | Previous: 648b19a | Ratio |
|---|---|---|---|
test_stream_read_xbrl.py::TestSteamReadXbrlZip::test_bench_stream_read_xbrl_zip |
2163624.19329921 iter/sec (stddev: 3.780747379996044e-8) |
1255233.5076991753 iter/sec (stddev: 8.217632107825769e-8) |
0.58 |
test_stream_read_xbrl.py::TestSkipInvalidFiles::test_bench_skip_invalid_files |
2136798.2674387484 iter/sec (stddev: 5.1457012237981926e-8) |
1253001.1272173189 iter/sec (stddev: 8.458168397230594e-8) |
0.59 |
test_stream_read_xbrl.py::TestStreamReadXbrlSync::test_bench_stream_read_xbrl_sync_default |
13.874427233529984 iter/sec (stddev: 0.001144745616909006) |
11.165225180683233 iter/sec (stddev: 0.0007675493912085805) |
0.80 |
test_stream_read_xbrl.py::TestStreamReadXbrlSync::test_bench_stream_read_xbrl_sync_not_end_of_month |
24.326727333315095 iter/sec (stddev: 0.0015917335358483584) |
16.75874000668306 iter/sec (stddev: 0.002082207520333416) |
0.69 |
test_stream_read_xbrl.py::TestStreamReadXbrlSync::test_bench_stream_read_xbrl_sync_end_of_month |
40.00663356307954 iter/sec (stddev: 0.0016531534180954557) |
23.294748263418942 iter/sec (stddev: 0.0009217285290204116) |
0.58 |
test_stream_read_xbrl.py::TestStreamReadXbrlSyncS3Csv::test_bench_stream_read_xbrl_sync_s3_csv |
106.27036958678629 iter/sec (stddev: 0.0003557278333128219) |
36.95863948122437 iter/sec (stddev: 0.008078193966523463) |
0.35 |
test_stream_read_xbrl.py::TestDebug::test_bench_debug |
630.3184247268205 iter/sec (stddev: 0.000031588500738030253) |
594.5422668407251 iter/sec (stddev: 0.000025442766986689107) |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Author
|
Hi @JosefSmith, tagging you as you're a recent committer to this repo. I'm trying to update the SRE contact information in this PR. |
JosefSmith
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work as part of SRE Jira ticket: https://uktrade.atlassian.net/browse/SR-4422. PR to update any existing references to sre@digital.trade.gov.uk, due to the upcoming deprecatiion of this inbox. SRE contact email address has been updated to sre@businessandtrade.gov.uk.