Stop implement-issue from parking for push approval - #40
Merged
Conversation
Skill step 10 told the agent to "request approval for git push", which contradicted operating-model step 10 (feature-branch pushes permitted). The task-specific skill won, so agents finished verified work then stalled waiting for a human go-ahead on the GitHub channel — the exact invisible-approval failure mode #17 set out to remove, resurfacing as an instruction rather than a tool gate. Observed live on #28. Align the skill with the operating model: push feature branches without approval. Safety is unchanged — the shell guard denies force-pushes and default-branch pushes, and merging stays human-only through required review and CODEOWNERS. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (observed live on #28)
The deepseek agent finished a fully-verified
.editorconfig, then stopped and asked permission togit pushand waited. Root cause: two contradictory step 10s —agent/instructions/20-operating-model.md§10: "Push the branch with git. Feature-branch pushes are permitted…" ✅agent/skills/implement-issue/SKILL.md§10: "Request approval forgit pushwhen the branch is ready." ❌The task-specific skill wins, so agents park after doing the work — re-creating the invisible-approval stall #17 removed at the tool layer, now as an instruction. On the GitHub channel that pause is a silent dead-end.
Fix
Rewrite skill step 10 to match the operating model: push feature branches without approval, and explicitly "Do not pause to ask before pushing a feature branch."
Safety unchanged
The
command-guardstill denies force-pushes and default-branch pushes (now unit-tested via #35), and merging remains human-only through required review + CODEOWNERS. Only the redundant, stall-inducing pause is removed.