fix(theme): distinguish active tabs in affected palettes#43
Conversation
|
Thank you for taking the time to put this together. I am a bit busy this weekend but I will hopefully find some time over the next few days to review and test. I also haven't taken an indepth look at this issue and will need to install Mini agains to check this issue/pull request out. But, just to clarify, this issue only occurs with Midnight and does not impact any other themes? There are other themes which also apply overrides to primary/secondary, I imagine if the issue impacts Midnight then it would also impact them as well. Can you verify that this issue does not occur with these themes?
|
b693fd1 to
7875430
Compare
|
Verified all five palettes in both dark and light modes with bold disabled. Abyss and Desert had the same low-distinction khaki pairing as Midnight, so 7875430 adds the same palette-local red override to those two. Scorpion and Sol already remain distinct and are unchanged. |
Summary
Why
The theme-role refactor maps the current tab in these palettes to a khaki color that is close to the hidden tab color, especially when bold styling is disabled. Palette-local values restore a distinct red active state without changing Scorpion, Sol, or unrelated themes.
Fixes #42.
Verification
git diff --check