Fix tokenization bugs and typos - #2
Open
kingusiu wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a handful of bugs encountered while running the VQ-VAE tokenization pipeline.
Changes
feature_dict_kin_massles_without_cuts.yaml→feature_dict_kin_massless_without_cuts.yamlalphaandkoptimizer params from the tokenization transformer experiment config — these aren't accepted byRangerLitebinning_cfgargument passed totokenize_jetclass_file(...)increate_tokenized_jetclass_files.py, which doesn't accept that parameter and caused aTypeErrorTesting
Ran
scripts/create_tokenized_jetclass_files.pyend-to-end against a trained VQ-VAE checkpoint to confirm tokenization completes without error.