Add a rule to check for non-private instance fields

[uhafner]

One important consequence of information hiding is to make fields of classes always private. This should be enforced with an architecture rule.

[github-actions]

☀️   Quality Monitor

Tests

     Unit Tests: ✅ successful — 87 passed $\textsf{(±0)}$, 2 skipped $\textsf{(±0)}$
   ⛔   Architecture Tests: ✅ successful — 18 passed $\color{green}{\textsf{(+1)}}$, 2 skipped $\textsf{(±0)}$

Coverage for New Code

   〰️   Line Coverage: 100.00% — perfect 🎉
   ➰   Branch Coverage: 100.00% — perfect 🎉
     Mutation Coverage: 100.00% — perfect 🎉
   💪   Test Strength: 100.00% — perfect 🎉

Coverage for Whole Project

   〰️   Line Coverage: 92.03% $\textsf{(±0)}$ — 64 missed lines
   ➰   Branch Coverage: 92.04% $\textsf{(±0)}$ — 18 missed branches
     Mutation Coverage: 91.16% $\textsf{(±0)}$ — 29 survived mutations
   💪   Test Strength: 93.15% $\textsf{(±0)}$ — 22 survived mutations in tested code

Style

     CheckStyle: No warnings $\textsf{(±0)}$
     PMD: No warnings $\textsf{(±0)}$
   ☕   Java Compiler: No warnings $\textsf{(±0)}$

Bugs

     SpotBugs: No bugs $\textsf{(±0)}$
   🐛   Error Prone: No bugs $\textsf{(±0)}$

API Problems

   🚫   Revapi: No warnings $\textsf{(±0)}$

Vulnerabilities

   🛡️   OWASP Dependency Check: No vulnerabilities $\textsf{(±0)}$

Software Metrics

   🌀   Cyclomatic Complexity: 397 (total)
   💭   Cognitive Complexity: 173 (total)
   ➿   N-Path Complexity: 361 (total)
   📏   Lines of Code: 4722 (total)
   📝   Non Commenting Source Statements: 1338 (total)
   🔗   Class Cohesion: 71.43% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)

📌 Reference Results

Delta reports computed against the reference results of e2cc757 in workflow run 26908169672.

🚦 Quality Gates

Overall Status: ✅ SUCCESS

✅ Passed Gates

• ✅ Overall Tests Success Rate: 100.00 >= 100.00
• ✅ Line Coverage in New Code: 100.00 >= 90.00
• ✅ Branch Coverage in New Code: 100.00 >= 90.00
• ✅ Mutation Coverage in New Code: 100.00 >= 90.00
• ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
• ✅ Style Violation in Whole Project: 0.00 <= 0.00

---

Created by Quality Monitor v4.15.0 (#82d77af). More details are shown in the GitHub Checks Result.