Skip to content

Enhanced Secret Fetching with Environment Variable Support - #113

Merged
fqjony merged 2 commits into
latestfrom
env-as-secret
Dec 3, 2025
Merged

Enhanced Secret Fetching with Environment Variable Support#113
fqjony merged 2 commits into
latestfrom
env-as-secret

Conversation

@fqjony

@fqjony fqjony commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Deployment environment variables always take precedence over worker.yaml config

Scenario with env set as secret ref over config.secrets

[INFO] Fetching secrets from configuration...
[INFO] Fetching secrets and setting them as environment variables.
[INFO] Environment: Skipping [TEST_ENV_SECRET] from config.secrets - will be resolved from deployment environment secret reference
[SUCCESS] Environment: Resolved secret for ANOTHER_TEST_ENV
[SUCCESS] Environment: Added all resolved secrets to environment file
[INFO] Checking for secret references in environment variables...
[INFO] Found secret reference in TEST_ENV_SECRET: gcp/rabbit-ci-dev/worker-secret-test
[INFO] Found 1 secret reference(s) in environment variables
[SUCCESS] Environment: Resolved secret for TEST_ENV_SECRET
[SUCCESS] Environment: Added all resolved secrets to environment file

Scenario with only config.secrets set

[INFO] Fetching secrets from configuration...
[INFO] Fetching secrets and setting them as environment variables.
[SUCCESS] Environment: Resolved secret for TEST_ENV_SECRET
[SUCCESS] Environment: Resolved secret for ANOTHER_TEST_ENV
[SUCCESS] Environment: Added all resolved secrets to environment file
[INFO] Checking for secret references in environment variables...
[INFO] No secret references found in environment variables.

Scenario with env set as static value ref over config.secrets

[INFO] Fetching secrets from configuration...
[INFO] Fetching secrets and setting them as environment variables.
[INFO] Environment: Skipping [TEST_ENV_SECRET] from config.secrets - using deployment environment static value
[SUCCESS] Environment: Resolved secret for ANOTHER_TEST_ENV
[SUCCESS] Environment: Added all resolved secrets to environment file
[INFO] Checking for secret references in environment variables...
[INFO] No secret references found in environment variables.

@fqjony
fqjony requested a review from a team December 3, 2025 11:43
@fqjony fqjony self-assigned this Dec 3, 2025
@fqjony fqjony added bug Something isn't working enhancement New feature or request labels Dec 3, 2025
@fqjony
fqjony merged commit 6990b0d into latest Dec 3, 2025
6 checks passed
@fqjony
fqjony deleted the env-as-secret branch December 3, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants