Env as Secret - #112
Conversation
fqjony
added
documentation
There was a problem hiding this comment.
Pull request overview
This PR adds support for secrets referenced directly in environment variables, allowing env vars to use the same provider/vault/secret format as the dedicated secrets section. Additionally, it updates Docker dependencies (Google Cloud SDK, yq, Python) and GitHub Actions to their latest versions, and introduces a new deploy.yml configuration file for streamlined deployment.
Key changes:
- Added functions to detect and resolve secret references in environment variables from both worker config and deployment environment
- Updated dependency versions across Dockerfile and GitHub Actions workflows
- Added deployment configuration file with example secret reference usage
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/secrets.sh | Implements secret reference detection and resolution for environment variables |
| lib/environment.sh | Integrates secret fetching from environment variables into configuration flow |
| docs/config.md | Documents the new secret reference feature in environment variables with examples |
| deploy.yml | Provides deployment configuration template with secret reference example |
| Dockerfile | Updates Python, Google Cloud SDK, and yq to newer versions |
| .github/workflows/release.yml | Updates checkout action from v5 to v6 |
| .github/workflows/codeql.yml | Updates checkout action from v5 to v6 |
| .github/workflows/build-and-test.yml | Updates checkout action from v5 to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes
deploy.ymlfor simple deploymentContainer logs
Worker Env Show