Fixed bug with sio3/socket interaction.#557
Open
RomanSyunyaev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the logic to accept() incoming socket connections for SIO3 was located exclusively within the altair_sio3_status_in() function. This caused a bug where a direct read from the data port (port 7) before a status poll (port 6) would fail to trigger the connection, resulting in zeroes being read as data.
I don't believe that's how original Altair 8800 worked -- while checking the status before reading was standard practice, it was not required. For example, some leader check routines won't work because of that: code that expects to poll the data stream directly would fail because the socket remained unaccepted.
This PR extracts the connection-checking logic into a helper function sio3_check_connection() and ensures it is called during both status and data input operations.