fix: fix runtime error caused by memory allocation issues in MajorPeaks#24
Open
danichang1 wants to merge 1 commit into
Open
fix: fix runtime error caused by memory allocation issues in MajorPeaks#24danichang1 wants to merge 1 commit into
danichang1 wants to merge 1 commit into
Conversation
aokiam
approved these changes
May 31, 2026
aokiam
left a comment
aokiam
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me! thanks for finding the bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was experiencing an issue in VibroSonics where rebuilding a major peaks module too many times would eventually lead to the ESP32 crashing and resetting. Using an ESP32 crash decoder, decoded backtrace to see that crash was occurring when attempting to allocate memory in MajorPeaks::resetPeaksArrays().
To fix this issue, switched from dynamically allocating and deleting memory for outputFrequencies and outputAmplitudes during runtime to statically allocating the memory initially.