Dj meal optimize - #123
Open
Division7 wants to merge 9 commits into
Open
Conversation
Division7
marked this pull request as ready for review
May 28, 2026 23:10
Division7
requested review from
DerekKirschbaum,
Wendy192837,
andrewc512,
divyanipunj,
kirrarista and
pconrad
as code owners
May 28, 2026 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excluded from Jacoco and Pitest because we don't want to start the actual database during unit tests: see #102
Reduces total n+1 query count from ~54 for 27 new items to ~28 (GenerationType.IDENTITY does not allow batching)
Added as a repository fragment because
@Querydoes not support iterable iterable clauses of this sort.Projects to a MenuItemDTO with an inbuilt, calculated review score at the database rather than the frontend.
Required a couple of integration/e2e changes to run with CurrentUserService.
To avoid having to reset each database with liquibase, Dining now gets its' own custom scheme, where new migration files start with a
Z_<order>to allow them to run in orderDeployed to https://dining-division7.dokku-00.cs.ucsb.edu/ -- I'd love any thoughts on the any of this