Render coverage using tints for datasets with multiple variants, otherwise older colour palette matching from the website. - #330
Open
adpeace wants to merge 2 commits into
Open
Render coverage using tints for datasets with multiple variants, otherwise older colour palette matching from the website.#330adpeace wants to merge 2 commits into
adpeace wants to merge 2 commits into
Conversation
The geotessera.org site assumes the older colourful legend is used, but when this tool renders coverage for v2 datasets it uses a tint per dataset. When there's only one data present it now defaults to the old swatch to match what geotessera.org expects.
Previously the tool always used the tint mode, but the prior commit changed this to use the old legend style to match the website when only a single variant was present. This change fixes the legend rendered by the CLI tool to match: use the old non-tint version when one variant is present, otherwise use the tints as before.
adpeace
marked this pull request as ready for review
July 23, 2026 21:23
Contributor
|
I'll merge this after trying it out on a few more variants; I'm not satisfied with the multi-variant tint either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
Testing:
uv run geotessera coverage -o coverage-dir (cd coverage-dir && python3 -m http.server)And checked the output. NOTE: I only have access to a dataset with a single variant so am not able to properly test the multiple-variant case.
AI usage declaration: Second commit for legend update written with the assistance of Claude, reviewed, updated, and approved by me. I'm hardly a typescript expert, though...