Fix to disallow additional properties in nested fields, eg, constraints - #21
Draft
george42-ctds wants to merge 1 commit into
Draft
Fix to disallow additional properties in nested fields, eg, constraints#21george42-ctds wants to merge 1 commit into
george42-ctds wants to merge 1 commit into
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
george42-ctds
marked this pull request as draft
July 21, 2025 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
fields-level specification of"additionalProperties": false,applies to a single level in our version of jsonschema. In newer versions the specification automatically applies to nested levels. In our version it does not apply to sub-levels such as
constraints.In the above,
additionalPropertiesmeans any properties present in the file that are not part of the schema.Additional properties under
constraintsare not checked in the validation process. They simply get passed through in the extraction process. A file withconstraints.enumLabelsandconstraints.foodoes not raise an error. The columns get passed through and they appear in converted files.If we want to disallow any additionalProperties in sub-levels (eg, constraints, StandardMappings) then we need to insert specifications in the sub-levels.
This branch has additional specifications in the sub-levels in the schema for json. Files with
constraints.enumLabelsandconstraints.foowill raise an error and will not generate converted output files.New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes