fix(CI): Refresh it#523
Closed
cnihelton wants to merge 13 commits into
Closed
Conversation
Since we build the package in CI we need to keep it in sync or install extra SDKs in the runners, which I find wasteful.
Just enough for CI to proceed plus fixing some warnings: - err shadowing redeclarations - unused param rootPath in generateMetaForRelease - no more ioutil - update imagick to v3
Upgrading it to Go 1.23, which was already in use in e2e.
- checkout to v6 - setup-go to v6 and use the go-version-file input.
No need for self-hosted runners, instead rely on windows-latest
Migrate to v8 Scope the GITHUB_TOKEN permissions accordingly. Some peasant fixes.
- Upgrades used actions - Use latest LTS from releases.u.c - Removes deprecated set-output usage
cnihelton
force-pushed
the
refresh-ci
branch
2 times, most recently
from
5e823e0 to
3d5276f
Compare
To output URLs pointing to cdimages.u.c or releases.u.c.
It used to show error codes like WSL_E_DISTRO_NOT_FOUND, but that's no longer the case. Parsing stdout is always a moving target. Exit codes are not an option because it exits -1 for any error.
Those tests are currently broken in obscure ways. We need to figure out which assumptions no longer hold. For example: https://github.com/ubuntu/WSL/actions/runs/27842627388/job/82404826746#step:9:59
But sometimes user@0.service still fails for reasons we don't fully control.
Commands may have prefixed or suffixed outputs, making them annoying to parse. test -e is silently failing, no idea of why.
Collaborator
Author
|
Let's try again. I want the automation to create the complementary PR on top of this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But the most important part is actually where the builder will source the images from. We no longer publish images to cloud-images.ubuntu.com since 24.10, and we have all supported images available in the new format at releases.u.c or cdimage.u.c (which one depends on the processor architecture). Thus I had to update a few places and changed the logic to determine the URL an image ought to be downloaded from.