chore(lint): stamp license headers with the current year#246
Open
behinddwalls wants to merge 1 commit into
Open
chore(lint): stamp license headers with the current year#246behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
sbalabanov
approved these changes
Jun 15, 2026
JamyDev
approved these changes
Jun 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
## Summary ### Why? The license-header linter pinned the copyright year to a hardcoded `2025` constant and required an exact match, so any file authored in a later year would need a manual constant bump — and bumping it would retroactively fail every existing file. ### What? The header is now validated by pattern: the copyright line matches `// Copyright (c) <YYYY> Uber Technologies, Inc.` for any 4-digit year, while the rest of the block must match exactly. The `-fix` mode stamps `time.Now().Year()`, so new files get the current year automatically with no future edits. Existing files (all `2025`) keep passing. Added test cases covering an older year, a wrong company, and a non-numeric year. ## Test Plan ✅ `bazel test //tool/linter/licenseheader:licenseheader_test` ✅ `bazel run //tool/linter/licenseheader -- -check` (whole repo still clean)
behinddwalls
force-pushed
the
preetam/licenseheader-year
branch
from
98bd7cb to
7cf1f8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The license-header linter pinned the copyright year to a hardcoded
2025constant and required an exact match, so any file authored in a later year would need a manual constant bump — and bumping it would retroactively fail every existing file.What?
The header is now validated by pattern: the copyright line matches
// Copyright (c) <YYYY> Uber Technologies, Inc.for any 4-digit year, while the rest of the block must match exactly. The-fixmode stampstime.Now().Year(), so new files get the current year automatically with no future edits. Existing files (all2025) keep passing. Added test cases covering an older year, a wrong company, and a non-numeric year.Test Plan
✅
bazel test //tool/linter/licenseheader:licenseheader_test✅
bazel run //tool/linter/licenseheader -- -check(whole repo still clean)