Fix missing ub__signin_margin dimen in :core that broke 3P authentication consumers - #270
Merged
Merged
Conversation
partha-uber
force-pushed
the
sirker-resource-linking-fix
branch
from
May 26, 2026 21:12
8e229a0 to
60cd952
Compare
lalwani
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported by a 3P consumer of
com.uber.sdk2:authentication:2.0.3:Root cause
authentication/src/main/res/values/styles.xmldefinesUberButton.Login, which references@dimen/ub__signin_margin.:authenticationdepends only on:core(the publishedcom.uber.sdk2:core).core/src/main/res/values/dimens.xmlmirrors most resources from the legacy:core-android, butub__signin_marginwas never copied over — it only existed in:core-android.com.uber.sdk2:authenticationget:coretransitively, but not the missing dimen — hence the AAPT error.The other resources the same style references (
ub__standard_padding,ub__secondary_text_size,@color/uber_black, theuber_logotype_*drawables,uber_button_background_selector_white) were correctly mirrored into:core, which is why no other resource errors surfaced.Fix
Add
<dimen name="ub__signin_margin">48dp</dimen>tocore/src/main/res/values/dimens.xml, matching the value and position used in:core-android. One-line change, restores the mirror.Test plan
./gradlew :authentication:assembleReleasebuilds successfully (verified locally — AAPT now resolvesub__signin_marginfor the AAR a 3P consumer pulls).com.uber.sdk2:authentication(built from this branch) in a sample app and confirmAndroid resource linking failedno longer occurs.