This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Prevent fetch calls on IDL files#89
Open
peats-bond wants to merge 1 commit into
Open
Conversation
This change prevents users from calling `idl fetch` on a thrift file. Users should be calling `fetch` with a service name instead. A reported issue discovered that `update` wasn't fetching the latest IDL for a service. Investigation showed that `meta.json` had incorrect entries: some `remotes` specified a `.thrift` extension. This indicates users calling `idl fetch` on a specifc IDL file. Reading the `meta.json` file on later calls to `fetch` and `update` caused IDL to silently fail with a 0 exit code. Users would see IDL updates up to the first invalid entry and then IDL would quit. This change will update entries with `.thrift` extensions for backwards compatibility.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents users from calling
idl fetchon a thriftfile. Users should be calling
fetchwith a service name instead.A reported issue discovered that
updatewasn't fetching the latestIDL for a service. Investigation showed that
meta.jsonhad incorrectentries: some
remotesspecified a.thriftextension. Thisindicates users calling
idl fetchon a specifc IDL file. Reading themeta.jsonfile on later calls tofetchandupdatecaused IDL tosilently fail with a 0 exit code.
Users would see IDL updates up to the first invalid entry and then IDL
would quit.
This change will update entries with
.thriftextensions forbackwards compatibility.