fix: skip WebAPK install to prevent SIGTRAP crash (#2932)#2978
Open
cykrr wants to merge 1 commit into
Open
Conversation
cykrr
force-pushed
the
fix/pwa-install-crash
branch
from
July 5, 2026 17:21
8656c5f to
fba28e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip WebAPK installation when user clicks 'Add to Home screen' / 'Install' on a PWA.
Cromite does not support WebAPKs (requires Google Play Services and googleapis.com, as documented in the README). When the 'Install' button is pressed, the WebAPK code path is triggered and hits a dangling raw_ptr crash (SIGTRAP) caught by BackupRefPtr protection.
This patch skips WebAPK installation entirely and creates a standard home screen shortcut directly, which is the documented supported behavior.
Fixes #2932