Skip to content

Fix ::backdrop/dialog/popover not appearing in top layer#2923

Draft
amoshydra wants to merge 1 commit into
uazo:masterfrom
amoshydra:fix-backdrop-overlay-ua-stylesheet
Draft

Fix ::backdrop/dialog/popover not appearing in top layer#2923
amoshydra wants to merge 1 commit into
uazo:masterfrom
amoshydra:fix-backdrop-overlay-ua-stylesheet

Conversation

@amoshydra

@amoshydra amoshydra commented May 25, 2026

Copy link
Copy Markdown

⚠️ this is a poc, not tested yet. I am not familiar with this code base. feel free to take over and re-create this PR

Description

Fix ::backdrop/dialog/popover not appearing in top layer

Disable-CSS-blink-feature-support.patch made ConsumeBlinkFeatureFn always return false, which broke @supports blink-feature(OverlayProperty) in the UA stylesheet. Upstream Chromium M147 wrapped dialog:modal { overlay: auto } inside @supports blink-feature(OverlayProperty), so this rule was never applied in Cromite, preventing dialog/popover from entering the top layer.

Fix: only block blink-feature() for author (website) stylesheets. UA stylesheets (browser built-in CSS like html.css) still need it.

Fixes #2918
Fixes #2895

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

Disable-CSS-blink-feature-support.patch made ConsumeBlinkFeatureFn always
return false, which broke @supports blink-feature(OverlayProperty) in the
UA stylesheet. Upstream Chromium M147 wrapped dialog:modal { overlay: auto }
inside @supports blink-feature(OverlayProperty), so this rule was never
applied in Cromite, preventing dialog/popover from entering the top layer.

Fix: only block blink-feature() for author (website) stylesheets. UA
stylesheets (browser built-in CSS like html.css) still need it.

Fixes uazo#2918
@larena1

larena1 commented Jun 3, 2026

Copy link
Copy Markdown

@uazo could you look into this ASAP? Many websites are unusable in Cromite currently, e.g. the search on Airbnb and others.

@uazo

uazo commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Thanks! Seriously, thank you for finding the bug!

Your code doesn't compile, but I'll take care of it now.
There's just one problem: when I wrote it, kUASheetMode was used for the Speculation Rules; I need to check if that's still the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

::backdrop css pseudo element not working Menu floating layer elements overlapping

3 participants