Fix ::backdrop/dialog/popover not appearing in top layer#2923
Draft
amoshydra wants to merge 1 commit into
Draft
Conversation
Disable-CSS-blink-feature-support.patch made ConsumeBlinkFeatureFn always return false, which broke @supports blink-feature(OverlayProperty) in the UA stylesheet. Upstream Chromium M147 wrapped dialog:modal { overlay: auto } inside @supports blink-feature(OverlayProperty), so this rule was never applied in Cromite, preventing dialog/popover from entering the top layer. Fix: only block blink-feature() for author (website) stylesheets. UA stylesheets (browser built-in CSS like html.css) still need it. Fixes uazo#2918
|
@uazo could you look into this ASAP? Many websites are unusable in Cromite currently, e.g. the search on Airbnb and others. |
Owner
|
Thanks! Seriously, thank you for finding the bug! Your code doesn't compile, but I'll take care of it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
::backdrop/dialog/popovernot appearing in top layerDisable-CSS-blink-feature-support.patchmadeConsumeBlinkFeatureFnalways return false, which broke@supports blink-feature(OverlayProperty)in the UA stylesheet. Upstream Chromium M147 wrappeddialog:modal { overlay: auto }inside@supports blink-feature(OverlayProperty), so this rule was never applied in Cromite, preventing dialog/popover from entering the top layer.Fix: only block
blink-feature()for author (website) stylesheets. UA stylesheets (browser built-in CSS like html.css) still need it.Fixes #2918
Fixes #2895
All submissions
Format
Subject: Alternative cache (NIK-based)->Alternative-cache-NIK-based.patch)