Remove pseudo-global warming models from hydroviz webapp endpoint - #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply removes a few chunks of code that were responsible for adding the two pseudo-global warming (PGW) models to the hydroviz webapp endpoint. We've decided to omit the PGW models for ease of communication on the webapp side, and because they use a different scenario (SSP2-4.5) vs. the four other CESM2 runs included in the dataset (SSP3-7.0).
To test, run the hydroviz webapp from the
gage_not_gaugebranch, pointed at theremove_pgw_hydrovizbranch of the Data API. Load a report for an Alaskan stream segment from the webapp, make sure all the charts still work as expected and confirm that only four (not six) "Projected" data points show up on the two circular polarscatter charts.Note: This PR affects the other Alaska charts, too, but you can't see the difference in data points on the other charts since they are showing either min/mean/max or boxplots. But the PGW data have been removed from the upstream code that is responsible for population all of these charts.