feat: add Virtual Marty Command API [STORY-004]#8
Closed
tzone85 wants to merge 1 commit into
Closed
Conversation
…em [STORY-004] Implement the core abstraction layer for the virtual Bluetooth bridge: - VirtualMarty class with all martypy API methods (movement, joint, status, sensor, sound) - CommandQueue with FIFO execution, blocking and non-blocking modes - MartyEventEmitter for command lifecycle events (start, complete, error, statusChange) - Full TypeScript interfaces exported for all command types - 65 tests passing with 89%+ branch coverage
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 0d6aa48 in 15 seconds. Click for details.
- Reviewed
1048lines of code in9files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_WCBtUZtnAzdfKsY4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/features/marty/types.tssrc/features/marty/event-emitter.tssrc/features/marty/command-queue.tssrc/features/marty/virtual-marty.tssrc/features/marty/index.tsTest plan
🤖 Generated with Claude Code
Important
Introduces
VirtualMartyAPI with command queue and event emitter for controlling a virtual robot, including comprehensive tests and TypeScript interfaces.VirtualMartyclass invirtual-marty.tswith methods for movement (e.g.,walk,dance), joint control (e.g.,eyes,arms), status (e.g.,is_moving,stop), sensors (e.g.,foot_on_ground), and sound (play_sound).MartyEventEmitterfor lifecycle events (commandStart,commandComplete,statusChange).CommandQueueincommand-queue.tsfor FIFO command processing.onProcessandonCompletecallbacks.MartyEventEmitterinevent-emitter.tsfor managing event listeners.types.tsfor commands, events, and statuses.VirtualMarty,CommandQueue, andMartyEventEmitterin respective test files.This description was created by
for 0d6aa48. You can customize this summary. It will automatically update as commits are pushed.