Skip to content

fix(middleware): always honor js_wait after selenium page load - #103

Merged
tharropoulos merged 2 commits into
typesense:masterfrom
tharropoulos:fix-middleware
May 27, 2026
Merged

fix(middleware): always honor js_wait after selenium page load#103
tharropoulos merged 2 commits into
typesense:masterfrom
tharropoulos:fix-middleware

Conversation

@tharropoulos

Copy link
Copy Markdown
Collaborator

closes #102

  • always sleep spider.js_wait after the WebDriverWait ready-state check, not only on timeout
  • skip the sleep when js_wait is 0 to preserve default behavior
  • add unit coverage for the fast-load, timeout, zero-wait, and js-render-disabled paths

@tharropoulos
tharropoulos merged commit 7fdb578 into typesense:master May 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

js_wait is not appreciated after upgrading from 0.11.0 to 0.12.0

1 participant