feat: complete media player playground example - #21
Merged
Conversation
SandroMaglione
force-pushed
the
codex/media-player-playground
branch
from
August 10, 2026 12:45
efe2dca to
dc1f5aa
Compare
SandroMaglione
marked this pull request as ready for review
August 10, 2026 12:46
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Effect runtime reference points
Effect Machine change from base
Effect runtime reference change from base
Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Runtime measurements on shared GitHub-hosted hardware remain informational, so small differences should be confirmed across multiple workflow runs. |
SandroMaglione
force-pushed
the
codex/media-player-playground
branch
from
August 10, 2026 13:40
dc1f5aa to
c10c83f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MachineTest.runservice-free for machines with invoked effects, matching the pure planning APIs it executesRoot cause
The original implementation used the removed
Machine.actionAPI, evaluatedHTMLAudioElementwhile loading tests in Node, and retained placeholder tests for the old state/event topology.MachineTest.runalso leaked invoke and internal runtime services in its public Effect requirement despite executing only pure planning.Changeset
src/orpackage.jsonAdded
.changeset/clean-scenarios-plan.mdfor theMachineTest.runservice-inference fix.Validation
pnpm checkpnpm checkinexamples/playgroundpnpm perf:typespasses within every configured instantiation budget.