Skip to content

Fix notification count and red dot not hidden in title - #242

Open
Dineshs91 wants to merge 1 commit into
graphite-base/242from
dinesh/04-16-fix_notification_count_and_red_dot_not_hidden_in_title
Open

Fix notification count and red dot not hidden in title#242
Dineshs91 wants to merge 1 commit into
graphite-base/242from
dinesh/04-16-fix_notification_count_and_red_dot_not_hidden_in_title

Conversation

@Dineshs91

@Dineshs91 Dineshs91 commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

Fix Title Notifications Feature

Updates the title notifications feature to work with the latest X/Twitter favicon naming convention, changing references from twitter.ico to twitter.3.ico and twitter-pip.2.ico to twitter-pip.3.ico. Also adds the title notifications feature to the dynamic features module so it can be toggled at runtime.

When notifications in title is turned off, the feature now properly restores the original favicon by replacing -pip.3 with .3 in the favicon URL.

I am also calling changeNotificationsTitle function from dynamic.js to handle case where notifications show up while I am already active on Twitter/X

Fix MIN-30 and #165

Dineshs91 commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dineshs91
Dineshs91 marked this pull request as ready for review April 16, 2025 15:06
@Dineshs91
Dineshs91 requested a review from linuz90 April 16, 2025 15:07
When notifications in title is turned off
@Dineshs91
Dineshs91 force-pushed the dinesh/04-16-fix_notification_count_and_red_dot_not_hidden_in_title branch from 52a172c to 3b10bc3 Compare April 30, 2025 14:20
@Dineshs91
Dineshs91 force-pushed the dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable branch from a1900dc to 0399e8d Compare April 30, 2025 14:20

Dineshs91 commented Apr 30, 2025

Copy link
Copy Markdown
Contributor Author

Merge activity

@Dineshs91
Dineshs91 changed the base branch from dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable to graphite-base/242 April 30, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants