Add given stage#451
Open
krishnangovindraj wants to merge 9 commits into
Open
Conversation
|
|
||
| preamble = { WITH ~ definition_function } | ||
|
|
||
| query_stage_given = { GIVEN ~ function_arguments ~ SEMICOLON } |
Member
Author
There was a problem hiding this comment.
Do we want to be able to specify rows inline?
given $s: string in [
["foo"],
["bar"],
]
Member
There was a problem hiding this comment.
Is it much work to add this right now? Or we can do it in a follow up ?
krishnangovindraj
force-pushed
the
add-inputs-stage
branch
from
035f566 to
cefc07d
Compare
krishnangovindraj
force-pushed
the
add-inputs-stage
branch
from
0687523 to
9fd0d1f
Compare
| let mut stages = | ||
| children.take_while_ref(|child| child.as_rule() == Rule::query_stage).map(visit_query_stage).collect_vec(); | ||
| let mut stages = Vec::new(); | ||
| stages.extend(children.try_consume_expected(Rule::query_stage_given).map(visit_query_stage_given)); |
Member
There was a problem hiding this comment.
oh you can extend a Vec with an Option? That's cool
Member
There was a problem hiding this comment.
Ah im guessing both are IntoIter right
|
|
||
| preamble = { WITH ~ definition_function } | ||
|
|
||
| query_stage_given = { GIVEN ~ function_arguments ~ SEMICOLON } |
Member
There was a problem hiding this comment.
do you wanna rename function_arguments to pipeline_arguments? I think that actually makes a lot of sense
flyingsilverfin
approved these changes
Jun 13, 2026
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| write!(f, "{} ", Keyword::Given)?; | ||
| write_joined!(f, ", ", self.variables)?; | ||
| Ok(()) |
Member
There was a problem hiding this comment.
Doesnt this need semicolon?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product change and motivation
Adds the 'given' stage to the language.