chore(sdk): drop private system-back routing patch, restoring LightActivity to upstream - #3
Merged
Merged
Conversation
…tivity to upstream Removes the local patch in LightActivity's OnBackPressedCallback that routed system back through the current screen's goBack() so it consulted viewModel.onBackPressed(). handleOnBackPressed() is now byte-identical to upstream: a plain goBack(). This is an accepted behavior loss, documented in light-workspace's upstream backlog rather than filed upstream now: multi-step screens (e.g. AddEntry's category grid -> amount entry) are popped outright on system back, dropping in-progress input, while the on-screen back button still handles it correctly. The patch could never ship through Light's builder anyway -- the builder extracts only tool/** and compiles against Light's official SDK, so changes to sdk/ never reach a published build. Dropping it keeps this repo in sync with upstream without merge conflicts. light-sudoku's variant of the same fix was already removed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the local patch inside
LightActivity'sOnBackPressedCallback.handleOnBackPressed()is now exactly upstream's version:sdk/client/src/main/kotlin/com/thelightphone/sdk/LightActivity.ktis now byte-identical toupstream/main—git diff upstream/main -- <that path>is empty.Why
Part of dropping private SDK patches so this repo syncs with upstream without conflicts.
tool/**and compiles against Light's official SDK, so nothing undersdk/reaches a published build.Scope
One file, one hunk. Deliberately untouched load-bearing deltas:
LightDb.kt'sdestructiveMigrationparam (three tool call sites depend on it), theLightSdkPluginisUnitTestConfigexemption, and thelint-ruleslint-api pin.Compilation is unaffected — the ViewModels override
onBackPressed(), an upstream hook that still exists; only this call site goes away.🤖 Generated with Claude Code