Skip to content

chore(sdk): drop private system-back routing patch, restoring LightActivity to upstream - #3

Merged
tyleryancey merged 1 commit into
mainfrom
chore/drop-backnav-patch
Jul 26, 2026
Merged

chore(sdk): drop private system-back routing patch, restoring LightActivity to upstream#3
tyleryancey merged 1 commit into
mainfrom
chore/drop-backnav-patch

Conversation

@tyleryancey

Copy link
Copy Markdown
Owner

What

Removes the local patch inside LightActivity's OnBackPressedCallback. handleOnBackPressed() is now exactly upstream's version:

override fun handleOnBackPressed() {
    goBack()
}

sdk/client/src/main/kotlin/com/thelightphone/sdk/LightActivity.kt is now byte-identical to upstream/maingit diff upstream/main -- <that path> is empty.

Why

Part of dropping private SDK patches so this repo syncs with upstream without conflicts.

  • Accepted behavior loss, documented in light-workspace's upstream backlog rather than filed upstream now. Multi-step screens (e.g. AddEntry's category grid -> amount entry) are popped outright on system back, dropping in-progress input; the on-screen back button still behaves correctly.
  • The patch could never ship anyway: Light's builder extracts only tool/** and compiles against Light's official SDK, so nothing under sdk/ reaches a published build.
  • light-sudoku's variant of the same fix was already removed.

Scope

One file, one hunk. Deliberately untouched load-bearing deltas: LightDb.kt's destructiveMigration param (three tool call sites depend on it), the LightSdkPlugin isUnitTestConfig exemption, and the lint-rules lint-api pin.

Compilation is unaffected — the ViewModels override onBackPressed(), an upstream hook that still exists; only this call site goes away.

🤖 Generated with Claude Code

…tivity to upstream

Removes the local patch in LightActivity's OnBackPressedCallback that routed
system back through the current screen's goBack() so it consulted
viewModel.onBackPressed(). handleOnBackPressed() is now byte-identical to
upstream: a plain goBack().

This is an accepted behavior loss, documented in light-workspace's upstream
backlog rather than filed upstream now: multi-step screens (e.g. AddEntry's
category grid -> amount entry) are popped outright on system back, dropping
in-progress input, while the on-screen back button still handles it correctly.

The patch could never ship through Light's builder anyway -- the builder
extracts only tool/** and compiles against Light's official SDK, so changes to
sdk/ never reach a published build. Dropping it keeps this repo in sync with
upstream without merge conflicts. light-sudoku's variant of the same fix was
already removed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@tyleryancey
tyleryancey merged commit 631273d into main Jul 26, 2026
2 checks passed
@tyleryancey
tyleryancey deleted the chore/drop-backnav-patch branch July 26, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant