Repository navigation
Dispatch CI for bot release merges and keep main runs - #406
Merged
Merged
Conversation
A pull request that sets project(arbiter VERSION 1.0.0) tags on merge after green CI. Bot release pushes use GITHUB_TOKEN, so version.yml now dispatches ci.yml on the release branch and again on the squash commit before it tags. Pull-request CI still cancels superseded runs; pushes to main do not. Co-authored-by: Tyler Reckart <tylerreckart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request that sets
project(arbiter VERSION 1.0.0)is the 1.0 cut. After it merges and CI is green on that main commit,version.ymltagsv1.0.0because CMakeLists is already ahead of the latest tag. It does not open a second release PR. Do not use Actions → Version bump → major for that cut.Bot-opened
chore(release): vX.Y.Zpulls are pushed and squash-merged withGITHUB_TOKEN. Those events do not start workflows. The version job now dispatchesci.ymlon the release branch, waits, squash-merges, dispatchesci.ymlon the squash commit, waits for that run, and only then tags. The tag is created only after a fresh fetch shows it is still absent.ci.ymlacceptsworkflow_dispatchso those dispatches have a workflow to start. Concurrency cancels an in-progress run only for pull requests. A push tomainno longer cancels another main run.The version job timeout is 150 minutes because it may wait on two CI runs, and the TSan leg's own budget is 60 minutes.
CONTRIBUTING.mddescribes the 1.0 pull-request path and names the five CI jobs that need to be required checks. Marking them required is a branch-protection change only Tyler can make.Tests
test_bump_version.sh(34 cases) andtest_require_ci_success.shpass locally. The version-step shell parses withbash -n.